ROOT Statistical Interference + Introdcing GitHub Actions for fitting results validation #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kholoimov
force-pushed
the
dev_python_impl
branch
9 times, most recently
from
a55db7a to
078f88f
Compare
guitargeek
reviewed
Sep 25, 2024
analyses/cms-open-data-ttbar/statistical_interference/agc_sample.py
Outdated
Show resolved
Hide resolved
guitargeek
reviewed
Sep 25, 2024
analyses/cms-open-data-ttbar/statistical_interference/agc_sample.py
Outdated
Show resolved
Hide resolved
guitargeek
reviewed
Sep 25, 2024
guitargeek
reviewed
Sep 25, 2024
guitargeek
reviewed
Sep 25, 2024
guitargeek
reviewed
Sep 25, 2024
analyses/cms-open-data-ttbar/statistical_interference/agc_sample.py
Outdated
Show resolved
Hide resolved
guitargeek
reviewed
Sep 25, 2024
analyses/cms-open-data-ttbar/statistical_interference/rebinning_tool.py
Outdated
Show resolved
Hide resolved
guitargeek
reviewed
Sep 25, 2024
guitargeek
reviewed
Sep 25, 2024
guitargeek
reviewed
Sep 25, 2024
analyses/cms-open-data-ttbar/statistical_interference/drawer.py
Outdated
Show resolved
Hide resolved
guitargeek
reviewed
Sep 25, 2024
vepadulano
requested changes
Oct 8, 2024
There was a problem hiding this comment.
Thanks! Some minor comments for consideration. And a general question: the new statistics pipeline produces quite some artifacts in .root files, those are not automatically git-ignored, should we add them explicitly to a .gitignore, clean them up after the analysis runs, or a mix of both?
analyses/cms-open-data-ttbar/statistical_inference/agc_sample.py
Outdated
Show resolved
Hide resolved
vepadulano
force-pushed
the
dev_python_impl
branch
3 times, most recently
from
a9ad8c5 to
9c45c5b
Compare
And also add a github action to validate results of the analysis and fitting
vepadulano
force-pushed
the
dev_python_impl
branch
from
9c45c5b to
a88200f
Compare
|
@kholoimov The CI action is green, amazing! Thanks again for this great work! I'm now merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.