Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tutorials] Modernisation of graph tutorials #17315

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

martamaja10
Copy link
Contributor

@martamaja10 martamaja10 commented Dec 19, 2024

Continuation of work from PR #17110.

Copy link

github-actions bot commented Dec 19, 2024

Test Results

    18 files      18 suites   4d 2h 37m 35s ⏱️
 2 695 tests  2 695 ✅ 0 💤 0 ❌
46 780 runs  46 780 ✅ 0 💤 0 ❌

Results for commit 5af9c18.

♻️ This comment has been updated with latest results.

@martamaja10 martamaja10 force-pushed the graphs-tuts branch 6 times, most recently from 7a41f39 to ac889f1 Compare December 19, 2024 17:40
@martamaja10 martamaja10 self-assigned this Dec 20, 2024
@martamaja10 martamaja10 force-pushed the graphs-tuts branch 5 times, most recently from 0a5a401 to 60a00f3 Compare January 10, 2025 15:30
@martamaja10 martamaja10 reopened this Jan 13, 2025
@martamaja10 martamaja10 force-pushed the graphs-tuts branch 3 times, most recently from 5299abe to c12e2a7 Compare January 14, 2025 12:50
@martamaja10 martamaja10 marked this pull request as ready for review January 14, 2025 12:50
Copy link
Member

@couet couet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments I made are just suggestions.

documentation/users-guide/Graphs.md Outdated Show resolved Hide resolved
documentation/users-guide/Graphs.md Outdated Show resolved Hide resolved
- graph.C: Using and drawing a simple TGraph.
- graph2derrorsfit.C: TGraph2D with errors drawing.
- gr001_basic.C: Using and drawing a simple TGraph.
- gr011_2Derrorsfit.C: TGraph2D with errors drawing.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"graph2d" keyword means the example is related to TGraph2D ( like graph is related to TGraph), is that still clear with the new name ?

hist/histpainter/src/TGraphPainter.cxx Show resolved Hide resolved
hist/histpainter/src/TGraphPainter.cxx Outdated Show resolved Hide resolved
Co-authored-by: Daniel P. Astudillo <[email protected]>
Co-authored-by: Emanuele Chiamulera <[email protected]>
Co-authored-by: Marta Czurylo <[email protected]>
@martamaja10 martamaja10 merged commit d009623 into root-project:master Jan 16, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants