[df] Integrate Report action with systematic variations #17396
+86
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vepadulano
force-pushed
the
rdf-vary-report
branch
from
23677bd to
e48e173
Compare
Test Results 16 files 16 suites 3d 18h 49m 56s ⏱️ Results for commit 98b0a2e. ♻️ This comment has been updated with latest results. |
This commit introduces the behaviour of the Report action in case systematic variations were requested, i.e. it is now possible to call VariationsFor(report). In order to create a different report per variation, the proper branch of the computation graph with the filters of the "varied universe" must be retrieved. This requires knowing which is the variation being requested when cloning the ReportHelper instance. To this end, the signature of the MakeNew protocol used by the action helpers is extended to optionally take the name of the variation being requested. When creating the varied helpers, the action also passes the name of the variation. A test for this new functionality has been added.
vepadulano
force-pushed
the
rdf-vary-report
branch
from
e48e173 to
98b0a2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces the behaviour of the Report action in case systematic variations were requested, i.e. it is now possible to call VariationsFor(report). In order to create a different report per variation, the proper branch of the computation graph with the filters of the "varied universe" must be retrieved. This requires knowing which is the variation being requested when cloning the ReportHelper instance. To this end, the signature of the MakeNew protocol used by the action helpers is extended to optionally take the name of the variation being requested. When creating the varied helpers, the action also passes the name of the variation. A test for this new functionality has been added.
Fixes #10551