[python] Pythonize TObject::Clone() overrides for correct ownership
#17399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guitargeek
force-pushed
the
tobject_clone_pyz
branch
from
d0d3146 to
da7bca3
Compare
Test Results 17 files 17 suites 3d 18h 50m 30s ⏱️ For more details on these failures, see this check. Results for commit da7bca3. |
This was referenced Jan 21, 2025
Following up on root-project#17250, also pythonizing the `TObject::Clone()` overrides to automatically give up the ownership. Thanks to the following forum post for noticing this problem: https://root-forum.cern.ch/t/a-question-about-root/62617
guitargeek
force-pushed
the
tobject_clone_pyz
branch
from
da7bca3 to
f9c8f8d
Compare
|
Backported to 6.34 in #17484. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #17250, also pythonizing the
TObject::Clone()overrides to automatically give up the ownership.Thanks to the following forum post for noticing this problem: https://root-forum.cern.ch/t/a-question-about-root/62617