[df] Improve warning message when lazy Snapshot is not triggered #17401
+34
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martamaja10
approved these changes
Jan 10, 2025
vepadulano
force-pushed
the
rdf-snapshot-lazy-improve-warning
branch
from
0bbec4a to
7316265
Compare
Test Results 17 files 17 suites 4d 8h 4m 11s ⏱️ Results for commit a40bf24. ♻️ This comment has been updated with latest results. |
vepadulano
force-pushed
the
rdf-snapshot-lazy-improve-warning
branch
from
7316265 to
fac1e57
Compare
The current message is not clear enough and may lead to confusing situations such as the one reported at https://root-forum.cern.ch/t/some-problem-with-lazy-snapshots-in-rdataframe/46740
vepadulano
force-pushed
the
rdf-snapshot-lazy-improve-warning
branch
from
fac1e57 to
a40bf24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current message is not clear enough and may lead to confusing situations such as the one reported at https://root-forum.cern.ch/t/some-problem-with-lazy-snapshots-in-rdataframe/46740