Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #11: restore missing irqs to the device.x file by securing generated file. #12

Merged
merged 3 commits into from
Feb 1, 2025

Conversation

solimike
Copy link
Contributor

@solimike solimike commented Jan 30, 2025

This PR fixes #11.

Simple change to the update script to secure the device.x file that svd2rust generated for us.

A couple of other changes that I hope are uncontroversial:

  1. I got some unintended changes to the ordering of the items in the Peripherals struct when I was testing locally that I tracked down to my locale, so I've enforced C locale in the sorting script. I have only tested locally on Ubuntu 24.04 and in the GH Actions and not on MacOS. However, I can't think it will behave differently on the "Darwin" arm of the sort.
  2. I have aligned the naming in the changelog with the naming that people settled on last time around (e.g. SW0_IRQ rather than SPAREIRQ0_IRQ)

Hope that's useful!

@9names 9names requested a review from thejpster February 1, 2025 05:43
@9names
Copy link
Member

9names commented Feb 1, 2025

@thejpster I don't have a mac to confirm the locale changes don't cause issues, can you confirm?
I will note that that the fix peripheral sort order stuff was annoying me and this PR has resolved it on Linux machine.

@solimike
Copy link
Contributor Author

solimike commented Feb 1, 2025

I have now managed to borrow a Mac and check out the "Darwin" path through sortFieldsAlphaNum.sh. All works as expected with no diffs from the Linux path.

Copy link
Member

@9names 9names left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for testing that.
LGTM

@9names 9names added this pull request to the merge queue Feb 1, 2025
Merged via the queue into rp-rs:main with commit e6003db Feb 1, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Software IRQs are missing from device.x leading to undefined symbols when linking
2 participants