Merge pull request #1424 from koic/fix_an_error_for_rails_strong_para…

…meters_expect [Fix #1423] Fix an error for `Rails/StrongParametersExpect`
rubocop · Jan 20, 2025 · 158cd38 · 158cd38
2 parents ce69ef7 + e48fec2
commit 158cd38
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/changelog/fix_an_error_for_rails_strong_parameters_expect.md b/changelog/fix_an_error_for_rails_strong_parameters_expect.md
@@ -0,0 +1 @@
+* [#1423](https://github.com/rubocop/rubocop-rails/issues/1423): Fix an error for `Rails/StrongParametersExpect` when using `permit` with no arguments. ([@koic][])
diff --git a/lib/rubocop/cop/rails/strong_parameters_expect.rb b/lib/rubocop/cop/rails/strong_parameters_expect.rb
@@ -32,7 +32,7 @@ class StrongParametersExpect < Base
         def_node_matcher :params_require_permit, <<~PATTERN
           $(call
             $(call
-              (send nil? :params) :require _) :permit ...)
+              (send nil? :params) :require _) :permit _+)
         PATTERN
 
         def_node_matcher :params_permit_require, <<~PATTERN

diff --git a/spec/rubocop/cop/rails/strong_parameters_expect_spec.rb b/spec/rubocop/cop/rails/strong_parameters_expect_spec.rb
@@ -136,6 +136,12 @@
       RUBY
     end
 
+    it 'does not register an offense when using `params.require(:target).permit`' do
+      expect_no_offenses(<<~RUBY)
+        params.require(:target).permit
+      RUBY
+    end
+
     it 'does not register an offense when using `params[:name]`' do
       expect_no_offenses(<<~RUBY)
         params[:name]
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		* [#1423](https://github.com/rubocop/rubocop-rails/issues/1423): Fix an error for `Rails/StrongParametersExpect` when using `permit` with no arguments. ([@koic][])