False positives for Rails/SaveBang for nested assignments

[ydakuka]

Describe the solution you'd like

it "does not register an offense when using persisted? after create and nested assignments" do
  expect_no_offenses(<<~RUBY)
    temp = (user = User.create)

    if temp.persisted?
      foo
    end
  RUBY
end

it "does not register an offense when assigning inside an if statement" do
  expect_no_offenses(<<~RUBY)
    if (user = User.create).persisted?
      foo
    end
  RUBY
end

Rubocop

$ rubocop -V
1.70.0 (using Parser 3.3.6.0, rubocop-ast 1.37.0, analyzing as Ruby 2.7, running on ruby 2.7.8) [x86_64-linux]
  - rubocop-capybara 2.21.0
  - rubocop-factory_bot 2.26.1
  - rubocop-performance 1.23.1
  - rubocop-rails 2.28.0
  - rubocop-rake 0.6.0
  - rubocop-rspec 3.3.0
  - rubocop-rspec_rails 2.30.0
  - rubocop-thread_safety 0.6.0

[tejasbubane]

I think this is because the cop is disabled by default?

rubocop-rails/config/default.yml

Lines 997 to 1005 in 158cd38

	Rails/SaveBang:
	Description: 'Identifies possible cases where Active Record save! or related should be used.'
	StyleGuide: 'https://rails.rubystyle.guide#save-bang'
	Enabled: false
	VersionAdded: '0.42'
	VersionChanged: '0.59'
	AllowImplicitReturn: true
	AllowedReceivers: []
	SafeAutoCorrect: false

[ydakuka]

No, I've checked it within rubocop-rails.