-
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make RSpec/ExampleWording handle "it will" future tense #1752
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
c5e511c
to
6d44680
Compare
cd92d7e
to
d346fd1
Compare
What is the project's preferred way to satisfy these offenses in the code? To me, breaking these small functions into smaller functions doesn't feel like a win.
|
You may want to silence the offense with a disable comment. |
d346fd1
to
5c19818
Compare
@ydah Thanks! I took this approach in the latest revision. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you.
Fixes #1751
Replace this text with a summary of the changes in your PR. The more detailed you are, the better.
Before submitting the PR make sure the following are checked:
master
(if not - rebase it).CHANGELOG.md
if the new code introduces user-observable changes.bundle exec rake
) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).If you have modified an existing cop's configuration options:
VersionChanged: "<<next>>"
inconfig/default.yml
.