Update .rubocop.yml, and disable OnSendWithoutOnCSend #2026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bquorning
force-pushed
the
regenerate-todo-file
branch
from
c758730 to
81f492d
Compare
|
My internal parser broke on |
|
I haven't looked through all the cops in here but it might be that the |
bquorning
added a commit
that referenced
this pull request
Feb 5, 2025
We keep InternalAffairs/OnSendWithoutOnCSend disabled, with the following reasoning (almost verbatim quoted from @dvandersluis[^1]): > Maybe the OnSendWithoutOnCSend cop doesn't make sense for > rubocop-rspec. There are not a lot of instances where safe navigation > would be used in tests, and anywhere that we're calling a method on a > constant or as a macro doesn't really need safe navigation support. [^1]: #2026 (comment)
bquorning
force-pushed
the
regenerate-todo-file
branch
from
81f492d to
9eb77cd
Compare
bquorning
changed the title
|
I decided to follow @dvandersluis’ advice and outright disable the OnSendWithoutOnCSend cop. I have update the PR to also include enabling of all pending cops up until the latest version. |
bquorning
force-pushed
the
regenerate-todo-file
branch
from
f8f762a to
9eb77cd
Compare
The oldest version of RuboCop may not be able to read our configuration file. That doesn't matter, we just need the version number, and assurance that the specs can run.
We keep InternalAffairs/OnSendWithoutOnCSend disabled, with the following reasoning (almost verbatim quoted from @dvandersluis[^1]): > Maybe the OnSendWithoutOnCSend cop doesn't make sense for > rubocop-rspec. There are not a lot of instances where safe navigation > would be used in tests, and anywhere that we're calling a method on a > constant or as a macro doesn't really need safe navigation support. [^1]: #2026 (comment)
bquorning
force-pushed
the
regenerate-todo-file
branch
from
9eb77cd to
3210f7d
Compare
ydah
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new cop InternalAffairs/OnSendWithoutOnCSend was added to RuboCop in rubocop/rubocop#13719.
cc @dvandersluis