Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add xz/liblzma blog post #184

Merged
merged 4 commits into from
Apr 2, 2024
Merged

Add xz/liblzma blog post #184

merged 4 commits into from
Apr 2, 2024

Conversation

segiddins
Copy link
Member

No description provided.

martinemde
martinemde approved these changes Mar 31, 2024
View reviewed changes
Copy link
Member

@martinemde martinemde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this up. Looks good with the small typo fix.

_posts/2024-03-31-rubygems-and-xz.md Outdated Show resolved Hide resolved
indirect
indirect approved these changes Mar 31, 2024
View reviewed changes
Copy link
Member

@indirect indirect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without any context or explanation, the phrase “as we use a musl based operating system (Alpine) for our RubyGems.org containers” comes across as a non-sequitur to me. Can we explain why that is relevant or worth mentioning?

duckinator
duckinator reviewed Apr 1, 2024
View reviewed changes
Copy link
Member

@duckinator duckinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some suggestions that I think make it a bit clearer. A lot of this is pretty subjective, though, so feel free to accept or reject individual changes as you like.

_posts/2024-03-31-rubygems-and-xz.md Outdated Show resolved Hide resolved
_posts/2024-03-31-rubygems-and-xz.md Outdated Show resolved Hide resolved
_posts/2024-03-31-rubygems-and-xz.md Outdated Show resolved Hide resolved
_posts/2024-03-31-rubygems-and-xz.md Outdated Show resolved Hide resolved
_posts/2024-03-31-rubygems-and-xz.md Outdated Show resolved Hide resolved
@simi simi self-requested a review April 1, 2024 10:42
@indirect indirect force-pushed the segiddins/add-xz-liblzma-blog-post branch from 58a0ebf to 3d69678 Compare April 2, 2024 23:17
@indirect indirect merged commit a4a659d into master Apr 2, 2024
1 check passed
@indirect indirect deleted the segiddins/add-xz-liblzma-blog-post branch April 2, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duckinator duckinator duckinator left review comments

@indirect indirect indirect approved these changes

@martinemde martinemde martinemde approved these changes

@simi simi simi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@segiddins @indirect @martinemde @duckinator @simi