text: Limit font name length to 64 characters in TextFormat #19263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
added
A-avm2
kjarosh
force-pushed
the
textformat-font-length
branch
from
d36c2f7 to
405be28
Compare
adrian17
reviewed
Jan 18, 2025
This test verifies the behavior of TextFormat.font and its maximum length.
This test verifies the behavior of TextFormat.font and its maximum length.
kjarosh
force-pushed
the
textformat-font-length
branch
from
405be28 to
0dbc263
Compare
Did more tests and it seems that no, it's just the AVM1/AVM2 setters which clamp it to 64 (e.g. it's not the case in HTML). The reason I implement this is CSS, where you can specify a list of fonts and the list can get quite large, but as AVM2 setters are used there, its length is clamped to 64. Regarding SWF tags, we have a buggy logic there anyway, because Flash treats each font class as a reference to a SWF tag, and not a font family per se (which we treat it as). I pushed fixes for AVM1 too (with a test). |
kjarosh
changed the title
kjarosh
added
text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's what Flash Player does ¯\_(ツ)_/¯