-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Goreleaser improvements #295
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
The ACTIONS_TOKEN serves the same purpose as GITHUB_TOKEN, the reason it is there - at the moment of creating this file, I was unaware that GITHUB_TOKEN automatically propagated by Github, so it's safe to replace ACTIONS_TOKEN with GITHUB_TOKEN with no adverse consequences. |
Tests are failing, they never worked on v3 in CI yet. |
Interesting. I will take a look when I can. |
Test failing has been replicated locally too. |
Sorry misread -- I guess leave it until the the tests are fixed then I will resync and you can re-approve. What did you want me to do with the TOKEN ? |
Yes, master tests are broken in a sense that they require some fixtures only present locally on my computer, haven't gotten around to fix that before real life hit me recently. If you could replace ACTIONS_TOKEN with GITHUB_TOKEN I would greatly appreciate it, and thank you! I'll get around to fix the tests soon, will merge this PR, because I think it's useful. |
I did this mostly to include the man page. But this also updates the versions of the actions used in github actions, and uses npmf to create packages.
You can see a sample of the files generated here:
https://github.com/arran4/slackdump/releases/tag/v2.5.8-test4
Also Goreleaser 2 is released https://goreleaser.com/blog/goreleaser-v2/
Thus I got:
And had to address it.
I am not sure of the purpose of having
ACTIONS_TOKEN
since there is an automatically generated oneGITHUB_TOKEN
(which I needed to use in order to test this.)I would recommend changing it if there isn't another reason for it.