Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only build defmt feature on stable rust + update dependencies #37

Conversation

rursprung
Copy link
Collaborator

see the individual commit messages for details

rursprung added 2 commits May 22, 2024 14:02
the old name is now raising a warning and will start failing in future
versions.
this has been introduced in cargo 1.74, thus we no longer need to define
it in the rustflags.
@rursprung rursprung added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels May 22, 2024
@rursprung rursprung requested a review from eldruin May 22, 2024 12:08
rursprung added 2 commits May 22, 2024 14:12
the MSRV of `defmt` does not guarantee that it builds on older rust
versions, accordingly we need to skip CI for older versions for feature
combinations where `defmt` is enabled.
@rursprung rursprung force-pushed the only-build-defmt-on-rust-stable branch from 27442bc to d254a71 Compare May 22, 2024 12:12
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eldruin eldruin merged commit 5856dca into rust-embedded-community:master May 22, 2024
8 checks passed
@rursprung rursprung deleted the only-build-defmt-on-rust-stable branch May 22, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants