Skip to content

Commit

Permalink
Removed UsbMidiEventPacket::message function
Browse files Browse the repository at this point in the history
  • Loading branch information
sourcebox committed Dec 19, 2024
1 parent d6383c8 commit 5b61102
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 9 deletions.
3 changes: 1 addition & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
### Added

- `UsbMidiEventPacket::cable_number` function.
- `UsbMidiEventPacket::message` function.
- `UsbMidiEventPacket::as_message_bytes` function.
- `UsbMidiEventPacket::as_raw_bytes` function.
- `UsbMidiEventPacket::to_raw_bytes` function.
Expand All @@ -34,7 +33,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
### Removed

- `UsbMidiEventPacket::cable_number` field, use function instead.
- `UsbMidiEventPacket::message` field, use function instead.
- `UsbMidiEventPacket::message` field, use `Message::try_from(&UsbMidiEventPacket)` instead.
- `UsbMidiEventPacket::from_midi` function, use `Message::into_packet` instead.

## [0.3.0] - 2024-05-27
Expand Down
9 changes: 2 additions & 7 deletions src/packet/event_packet.rs
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ pub struct UsbMidiEventPacket {
impl From<UsbMidiEventPacket> for [u8; 4] {
fn from(value: UsbMidiEventPacket) -> [u8; 4] {
let cable_number = U4::from(value.cable_number());
let message = value.message();
let message = Message::try_from(&value).unwrap();
let index_number = {
let code_index = CodeIndexNumber::find_from_message(&message);
U4::from(code_index)
Expand Down Expand Up @@ -74,14 +74,9 @@ impl UsbMidiEventPacket {
CableNumber::try_from(raw_cable_number).unwrap()
}

/// Returns the message.
pub fn message(&self) -> Message {
Message::try_from(&self.raw[1..]).unwrap()
}

/// Returns a slice to the message bytes. The length is dependent on the message type.
pub fn as_message_bytes(&self) -> &[u8] {
let r = Raw::from(self.message());
let r = Raw::from(Message::try_from(self).unwrap());
let length = match r.payload {
Payload::Empty => 1,
Payload::SingleByte(_) => 2,
Expand Down

0 comments on commit 5b61102

Please sign in to comment.