Write Builders manually #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A lot of noise from cargo fmt (I assume). Could you split it up? |
|
I don't think the rustfmt noise is too present. Do you mean we should rustfmt before this PR? |
|
No, I mean one commit for rustfmt and one with the builder changes. |
|
I am not able to split them. |
Same thing. ;) |
Emilgardis
requested changes
Nov 18, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bors bot
added a commit
that referenced
this pull request
Feb 11, 2020
106: serde skip serialization r=therealprof a=burrbull Part of #101 This change should not be breaking. Co-authored-by: Andrey Zgarbul <[email protected]>
burrbull
force-pushed
the
build
branch
2 times, most recently
from
276845c to
1b5234d
Compare
|
@Emilgardis What is the status of this PR? I'm trying to remove an outdated in-tree version of |
|
Closed. See #115 |
bors bot
added a commit
that referenced
this pull request
Apr 25, 2020
115: Write Builders manually 2 r=Emilgardis a=burrbull #101 without changes in Error hierarchy. Should slightly be easier to review. Co-authored-by: Andrey Zgarbul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.