Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always trim whitespaces #229

Merged
merged 1 commit into from
Sep 16, 2023
Merged

always trim whitespaces #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions svd-parser/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
## Unreleased

- Bump MSRV to 1.58.0
- Ignore whitespaces around tag contents

## [v0.14.1] - 2022-10-23

Expand Down
3 changes: 2 additions & 1 deletion svd-parser/src/elementext.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@ impl<'a, 'input> ElementExt for Node<'a, 'input> {
/// Get text contained by an XML Element
fn get_text(&self) -> Result<&str, SVDErrorAt> {
match self.text() {
Some(s) => Ok(s),
// TODO: return error on `strict`
Some(s) => Ok(s.trim()),
// FIXME: Doesn't look good because SVDError doesn't format by itself. We already
// capture the element and this information can be used for getting the name
// This would fix ParseError
Expand Down