-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove archived, unmaintained or low downloads crates #437
Conversation
probably best to split this into two PR since these changes are not exactly related to each other 😅 |
Oh sure thing I can do that, I just didn't want to add too much overhead for such small changes but this makes sense! edit: github actions commit moved to #438 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have never heard of the majority of the removed crates, so that's probably a good indication that removing them might be fine 😅
I've found two where I'm not sure.
@LukeMathWalker any thoughts from your side?
@@ -17,7 +17,6 @@ packages = [ | |||
"syslog", | |||
"flexi_logger", | |||
"sentry", | |||
"slog", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
slog seems reasonably active at first glance and seems to have decent download numbers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup it's mostly because of the notice on their readme that I removed it, but I don't mind leaving it if you want.
You might consider using tracing instead
It's been a while since slog was created and it served Rust community well all this time. It remains a stable, featureful and battle-tested library, used in many important projects.
In last few years, another ecosystem for Rust was created with similar features and a very good support for debugging async code and already larger dev team and community.
Please check tracing and see if it is more suitable for your use-case. It seems that it is already a go-to logging/tracing solution for Rust.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, I see, thanks :)
"maud", | ||
"markup", | ||
"pulldown-cmark", | ||
"ramhorns", | ||
"ructe", | ||
"axohtml", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this one got removed because of low download numbers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely
"rocket", | ||
"tide", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we removing tide
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There has not been any updates for 3 years and as of May 2022 the project is not under active development. The amount of downloads is still high, so it's not an easy decision to keep it or not. I don't mind either solution, just doing my best to revive this repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's stick to the criteria we agreed upon in #127 (comment)
Based on that, I don't see a reason to remove it.
We should reify the criteria we agreed upon in #127 in |
Opened #440 |
|
☝🏻 @adriantombu? |
I guess this is a good time to write a script to automate this. Let me see if I have some time today. |
I believe I got a tunneling effect that made me focus on the red colors in the charts, making me discarding the blueish as old/irrelevant. It's my mistake so I can work on fixing that if you want @LukeMathWalker. |
If you have time, please do! |
I don't really have time but I'll try to find some 😅 |
I went through all of the crates (🥵) and checked their status (archived our unmaintained) and recent download count. I stayed conservative, but there are probably more that will be removed in the future (quality over quantity).
This is the first step before checking all the PR's and issues to do some much needed cleaning in the repo.