-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggest similar feature names on CLI #15133
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @weihanglo (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
@rustbot label A-diagnostics -A-dependency-resolution |
Thanks for adding this! |
Does rustbot know something I don't? If it insists on that label, I'm not going to fight it. |
It's because you're editing files within the resolver. Don't worry about it. |
Can you restructure your PR
|
a44b7f0
to
7b9140f
Compare
7b9140f
to
3d30671
Compare
What does this PR try to resolve?
When you typo a feature name on the CLI, the error message isn't very helpful. Concretely, I was testing a PR which adds a feature called
cosmic_text
to enable acosmic-text
dependency, and got a correct but unhelpful error message:I had to dig into the Cargo.lock file to find out how to fix this.
How should we test and review this PR?
The existing tests seem to cover this quite well. I don't think that this feature warrants adding its own test.