Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote ohos targets to tier2 with host tools. #137011

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

LuuuXXX
Copy link
Contributor

@LuuuXXX LuuuXXX commented Feb 14, 2025

What does this PR try to resolve?

Try to promote the following [Tier 2 without Host Tools](https://doc.rust-lang.org/rustc/platform-support.html#tier-2-without-host-tools) targets to [Tier 2 with Host Tools](https://doc.rust-lang.org/rustc/platform-support.html#tier-2-with-host-tools):

  • aarch64-unknown-linux-ohos
  • armv7-unknown-linux-ohos
  • x86_64-unknown-linux-ohos

More Information?

see MCP: rust-lang/compiler-team#811

Blockage to be solved?

  • Submit an MCP
  • Submit code of promote ohos targets
  • Resolve related dependencies (measureme

The modified code of the measureme has been merged (see https://github.com/rust-lang/measureme/pull/238). [done]
The new version will was released (rust-lang/measureme#240). [done]

@rustbot
Copy link
Collaborator

rustbot commented Feb 14, 2025

r? @Kobzol

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Feb 14, 2025
@rustbot
Copy link
Collaborator

rustbot commented Feb 14, 2025

This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp.

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@LuuuXXX LuuuXXX changed the title 【WIP】Promote ohos targets to tier2 with host tools. [WIP] Promote ohos targets to tier2 with host tools. Feb 14, 2025
@rust-log-analyzer

This comment has been minimized.

@LuuuXXX
Copy link
Contributor Author

LuuuXXX commented Feb 14, 2025

The measureme-mirror used to replace the measureme cannot pass the tidy check. It seems that a new measureme version is required.

@Kobzol
Copy link
Contributor

Kobzol commented Feb 14, 2025

This job runs on the free GitHub runners, so in terms of infra cost, the build time increase should be fine.

@LuuuXXX
Copy link
Contributor Author

LuuuXXX commented Feb 15, 2025

Very appreciate it.

@LuuuXXX LuuuXXX changed the title [WIP] Promote ohos targets to tier2 with host tools. Promote ohos targets to tier2 with host tools. Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants