Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sccache in CI to 0.9.1 #137023

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Feb 14, 2025

We haven't updated the used sccache version for years, it has accrued a bunch of fixes and features in the meantime. It now supports the --show-adv-stats flag, which gives a more detailed summary of the results of caching. And it can also cache Rust code, which could be useful in the future (#136942 - although now there are no large wins).

It also supports caching PGO now, but since the PGO profiles are always different, it won't make any real difference.

#133076 previously tried to update the version to 0.3 (CC @klensy)

r? @marcoieni

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Feb 14, 2025
@Kobzol
Copy link
Contributor Author

Kobzol commented Feb 14, 2025

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 14, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 14, 2025
Bump sccache in CI to 0.9.1

We haven't updated the used sccache version for years, it has accrued a bunch of fixes and features in the meantime. It now supports the `--show-adv-stats` flag, which gives a more detailed summary of the results of caching. And it can also cache Rust code, which could be useful in the future (rust-lang#136942 - although now there are no large wins).

It also supports caching PGO now, but since the PGO profiles are always different, it won't make any real difference.

rust-lang#133076 previously tried to update the version to 0.3 (CC `@klensy)`

r? `@marcoieni`
@bors
Copy link
Contributor

bors commented Feb 14, 2025

⌛ Trying commit 0d0a2a3 with merge 37b4ba8...

@klensy
Copy link
Contributor

klensy commented Feb 14, 2025

In my attempts to update sccache, i remember that it reported successful cached calls for jobs, where it didn't actually used (for llvm caching), i found it weird.

So someone was using, but idk who.

@bors
Copy link
Contributor

bors commented Feb 14, 2025

☀️ Try build successful - checks-actions
Build commit: 37b4ba8 (37b4ba88136d3da74d8cfd30fbabc8fef82f07f3)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (37b4ba8): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 787.772s -> 790.42s (0.34%)
Artifact size: 348.36 MiB -> 348.35 MiB (-0.00%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 14, 2025
@marcoieni
Copy link
Member

LGTM. Feel free to r=me 👍

@Kobzol
Copy link
Contributor Author

Kobzol commented Feb 14, 2025

@bors r=marcoieni rollup=never

@bors
Copy link
Contributor

bors commented Feb 14, 2025

📌 Commit 0d0a2a3 has been approved by marcoieni

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants