-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump sccache in CI to 0.9.1 #137023
base: master
Are you sure you want to change the base?
Bump sccache in CI to 0.9.1 #137023
Conversation
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
Bump sccache in CI to 0.9.1 We haven't updated the used sccache version for years, it has accrued a bunch of fixes and features in the meantime. It now supports the `--show-adv-stats` flag, which gives a more detailed summary of the results of caching. And it can also cache Rust code, which could be useful in the future (rust-lang#136942 - although now there are no large wins). It also supports caching PGO now, but since the PGO profiles are always different, it won't make any real difference. rust-lang#133076 previously tried to update the version to 0.3 (CC `@klensy)` r? `@marcoieni`
In my attempts to update sccache, i remember that it reported successful cached calls for jobs, where it didn't actually used (for llvm caching), i found it weird. So someone was using, but idk who. |
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (37b4ba8): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 787.772s -> 790.42s (0.34%) |
LGTM. Feel free to r=me 👍 |
@bors r=marcoieni rollup=never |
We haven't updated the used sccache version for years, it has accrued a bunch of fixes and features in the meantime. It now supports the
--show-adv-stats
flag, which gives a more detailed summary of the results of caching. And it can also cache Rust code, which could be useful in the future (#136942 - although now there are no large wins).It also supports caching PGO now, but since the PGO profiles are always different, it won't make any real difference.
#133076 previously tried to update the version to 0.3 (CC @klensy)
r? @marcoieni