Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize (and const-stabilize) integer_sign_cast #137026

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Stabilize (and const-stabilize) integer_sign_cast #137026

wants to merge 1 commit into from
+8 −9

Conversation

GrigorenkoPV
Copy link
Contributor

@GrigorenkoPV GrigorenkoPV commented Feb 14, 2025 •
edited
Loading

Tracking issue: #125882
Closes: #125882
FCP completed: #125882 (comment)

@rustbot
Copy link
Collaborator

rustbot commented Feb 14, 2025

r? @Noratrieb

rustbot has assigned @Noratrieb.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 14, 2025
@Noratrieb
Copy link
Member

cool!
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 14, 2025

📌 Commit e8a4f9d has been approved by Noratrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 14, 2025
jhpratt added a commit to jhpratt/rust that referenced this pull request Feb 14, 2025
@jhpratt
Rollup merge of rust-lang#137026 - GrigorenkoPV:integer_sign_cast, r=…
3cbe03f 
…Noratrieb

Stabilize (and const-stabilize) `integer_sign_cast`

Tracking issue: rust-lang#125882
Closes: rust-lang#125882
FCP completed: rust-lang#125882 (comment)
@jhpratt jhpratt mentioned this pull request Feb 14, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 14, 2025
@bors
Auto merge of rust-lang#137040 - jhpratt:rollup-lr17zya, r=jhpratt
a931943 
Rollup of 11 pull requests

Successful merges:

 - rust-lang#133312 (triagebot: automatically add more rustdoc related labels)
 - rust-lang#134016 (Stabilize `const_is_char_boundary` and `const_str_split_at`.)
 - rust-lang#135813 (CI: split i686-mingw job to three free runners)
 - rust-lang#136879 (Add safe new() to NotAllOnes)
 - rust-lang#136971 (Add a new check-pass UI test for returning `impl Fn(T) -> impl Trait`)
 - rust-lang#136983 (Prepare standard library for Rust 2024 migration)
 - rust-lang#137002 (Fix early lint check desc in query)
 - rust-lang#137006 (borrowck diagnostics cleanup: remove an unused and a barely-used field)
 - rust-lang#137026 (Stabilize (and const-stabilize) `integer_sign_cast`)
 - rust-lang#137028 (mir_build: Clarify some code for lowering `hir::PatExpr` to THIR)
 - rust-lang#137032 (Decode metadata buffer in one go)

r? `@ghost`
`@rustbot` modify labels: rollup
@GrigorenkoPV
Copy link
Contributor Author

I don't think I can r- this, so I will temporary close it instead.

A concern has been voiced (sadly, not in time for FCP) about using as_[un]signed as a name for the methods:
#125882 (comment)

I quite like this proposal, and I don't think this option was mentioned anywhere (ACP, tracking issue, or implementation PR). I would like to hear what t-libs has to say about it first.

@GrigorenkoPV
Copy link
Contributor Author

GrigorenkoPV commented Feb 14, 2025 •
edited
Loading

Sorry, if this is a bit in violation of the usual process, but I hope it's not too much of a sabotage. I don't think this stabilization is currently blocking any other work, and it's probably better to get the API right than fast.

UPD: closing and reopening did not remove the approval, so I've rebased instead.

@rustbot label -S-waiting-on-bors +S-waiting-on-team -T-libs +T-libs-api

@GrigorenkoPV GrigorenkoPV reopened this Feb 14, 2025
@rustbot rustbot added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 14, 2025
@GrigorenkoPV GrigorenkoPV mentioned this pull request Feb 14, 2025
Open
3 tasks
@scottmcm
Copy link
Member

scottmcm commented Feb 15, 2025 •
edited
Loading

Given the comments from the author above,
@bors r-
(just in case)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). labels Feb 15, 2025
@scottmcm scottmcm added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Noratrieb Noratrieb

Labels
S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracking Issue for integer_sign_cast
5 participants
@GrigorenkoPV @rustbot @Noratrieb @bors @scottmcm