Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid formatting when line comment before comma #5793

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fee1-dead
Copy link
Member

Resolves #5784. Code may not be the best. Another way to do this might be for the list code to accept the end of list span as a parameter such that we can recover comments between the last item and the end that way, to avoid special casing the last item in the list.

@calebcartwright
Copy link
Member

Another way to do this might be for the list code to accept the end of list span as a parameter such that we can recover comments between the last item and the end that way, to avoid special casing the last item in the list.

I like the sound of that idea. Is it something you'd have the interest/bandwidth to experiment with?

@fee1-dead
Copy link
Member Author

I just came back to this and tried to make sense of it. The problem is that I can't seem to recall why I wrote that in the PR description, as I don't see an alternative for this fix. Maybe the domain specific knowledge has just been lost...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Formatting match arm with a comment between the expression and the comma causes invalid code
3 participants