Clear CARGO
environment variable in cargo proxy
#4175
+136
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rust-lang/clippy#15099
To recount the problem (copied from rust-lang/cargo#15099 (comment)):
cargo
proxy runs, selects the defaultcargo
, and sets theCARGO
environment variable to default toolchain'scargo
.cargo
invocations runs some other code, which invokescargo +<toolchain> <subcommand>
.<subcommand>
reads theCARGO
environment variable and runs the default toolchain'scargo
rather than<toolchain>
'scargo
.This PR fixes the problem by clearing the
CARGO
environment variable in the proxy whencargo +<toolchain> <subcommand>
is run.This PR is currently organized as eight commits:
$CARGO
passed to external subcommands can point to the wrongcargo
if already set cargo#15099 (comment).Config::cmd
.Nits are welcome.