Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phil davis issue 588 #628

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Phil davis issue 588 #628

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
605cee3
Bump dependencies in composer.json
phil-davis Sep 11, 2022
f0aeaba
Increase phpstan to level 6
phil-davis Sep 11, 2022
3fe0960
Adjust mostly test code for phpstan level 6
phil-davis Sep 11, 2022
14c482b
Declare more types in tests
phil-davis Sep 13, 2022
96d2b0d
Remove useless check of propertyCounters < 1
phil-davis Sep 14, 2022
4fda87f
Adjust some type declarations in lib/Component.php
phil-davis Sep 14, 2022
e4777ff
Remove phpstan-ignore-line from lines that no longer give a phpstan e…
phil-davis Sep 14, 2022
1baf535
Fixup phpstan errors in lib/Component/VEvent.php
phil-davis Sep 14, 2022
4aa9c7f
add ATTENDEE to possible magic properties of VEvent
phil-davis Sep 14, 2022
d0398cb
Adjust tests to remove phpstan errors
phil-davis Sep 14, 2022
a7745a6
Move public string 'name' into Node
phil-davis Sep 14, 2022
0b50fa3
Add dollar in front of @property variables
phil-davis Jan 23, 2023
8d14f74
Fixup phpstan things reported in MainTest
phil-davis Jan 23, 2023
2bd8ee5
Fix cs-style
phil-davis Jan 23, 2023
d09fcf3
Fix things reported by phpstan in tests
phil-davis Jan 23, 2023
e8d39e6
Adjust types in lib/Writer.php
phil-davis Jan 23, 2023
719bac9
Adjust types in lib/VCardConverter.php
phil-davis Jan 23, 2023
bf44efb
Call static assert functions with self::
phil-davis Feb 8, 2023
ef31eff
fix: left over phpstan errors after rebase
DeepDiver1975 Nov 8, 2023
bccb315
fix: declare iterator type on class Node + array types in ICalendar
DeepDiver1975 Nov 8, 2023
4c449ce
fix: cs-fixer
DeepDiver1975 Nov 8, 2023
8d45cf0
ci: add php 8.3
DeepDiver1975 Nov 8, 2023
6805cf2
fix: type declarations when using VCalendar->VEVENT
DeepDiver1975 Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/Node.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
* @author Evert Pot (http://evertpot.com/)
* @license http://sabre.io/license/ Modified BSD License
*/

/** @implements \IteratorAggregate<int, Node> */
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not too sure if this is the correct approach ... it can also hold sub classes of Node .....

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phil-davis @staabm what do you think?
Any better options?

abstract class Node implements \IteratorAggregate, \ArrayAccess, \Countable, \JsonSerializable, Xml\XmlSerializable
{
/**
Expand Down
2 changes: 2 additions & 0 deletions lib/Splitter/ICalendar.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,13 @@ class ICalendar implements SplitterInterface
/**
* Timezones.
*/
/** @var array<string, Component\VTimeZone> */
protected array $vtimezones = [];

/**
* iCalendar objects.
*/
/** @var array<string, Component> */
protected array $objects = [];

/**
Expand Down
Loading