Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.5] Handle summer time jumps in event recurrences #660

Merged
merged 19 commits into from
Jul 2, 2024

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jun 6, 2024

Backport #653 to 4.5 release branch

ToDo:

  • remove PHP 7.4 features used (4.5.x releases support all the way back to PHP 7.1)

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.65%. Comparing base (eb2c41e) to head (b7f45de).
Report is 4 commits behind head on 4.5.

Additional details and impacted files
@@             Coverage Diff              @@
##                4.5     #660      +/-   ##
============================================
+ Coverage     98.38%   98.65%   +0.27%     
- Complexity     1813     1907      +94     
============================================
  Files            71       71              
  Lines          4334     5294     +960     
============================================
+ Hits           4264     5223     +959     
- Misses           70       71       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phil-davis
Copy link
Contributor Author

Note: the original PR had 19 commits. This only has 18 commits because one of the 19 was just a single-character format change, which I ended up including with the commit before it when cherry-picking and resolving conflicts etc.

The "missing" commit is:
b37ef3d

@phil-davis
Copy link
Contributor Author

And the new 19th commit is to remove PHP language features that are not available in PHP 7.1 7.2 7.3

@phil-davis
Copy link
Contributor Author

Moving forward...

@phil-davis phil-davis merged commit 2aeb4fc into sabre-io:4.5 Jul 2, 2024
10 checks passed
@phil-davis phil-davis deleted the dst-leap-648-4.5 branch July 2, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants