Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application should not run as root. enable nonroot scc for application . #20

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ Execute the following commands:
```
oc new-project bookinfo
oc annotate namespace bookinfo istio-pod-network-controller/initialize=true
oc adm policy add-scc-to-user anyuid -z default -n bookinfo
oc adm policy add-scc-to-user nonroot -z default -n bookinfo
oc apply -f <(istioctl kube-inject -f examples/bookinfo.yaml) -n bookinfo
oc expose svc productpage -n bookinfo
```
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,8 @@ data:
- name: istio-init
image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"
imagePullPolicy: {{ .Values.image.pullPolicy }}
securityContext:
runAsUser: {{ .Values.image.runAsUser }}
args:
- init
volumeMounts:
Expand Down
3 changes: 2 additions & 1 deletion chart/istio-pod-network-controller/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,9 @@ runcRoot: /run/runc

image:
repository: quay.io/raffaelespazzoli/istio-pod-network-controller
tag: latest
tag: v1
pullPolicy: IfNotPresent
runAsUser: 1337

resources: {}
# We usually recommend not to specify default resources and to leave this as a conscious
Expand Down