Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some details in schemes, typing annotation for gens #39579

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

some details in schemes, typing annotation for gens #39579

wants to merge 2 commits into from

Conversation

fchapoton
Copy link
Contributor

adding a little bit of typing annotation for gens methods in schemes

There remains several such methods in elliptic_curves that return lists and should be changed later to return tuples.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 24, 2025 •
edited
Loading

Documentation preview for this PR (built with commit b4eeda7; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@vincentmacri
Copy link
Contributor

LGTM

@fchapoton
Copy link
Contributor Author

back to positive after trivial merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentmacri vincentmacri vincentmacri approved these changes

Assignees
No one assigned
Labels
s: positive review t: refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fchapoton @vincentmacri