Have salsa not depend on salsa-macros #750
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for salsa-rs canceled.
|
Veykril
commented
Mar 8, 2025
Comment on lines
+91
to
+105
|
|
||
| #[doc(hidden)] | ||
| fn zalsa_register_downcaster(&self) { | ||
| // The no-op downcaster is special cased in view caster construction. | ||
| } | ||
|
|
||
| #[doc(hidden)] | ||
| #[inline(always)] | ||
| unsafe fn downcast(db: &dyn Database) -> &dyn Database | ||
| where | ||
| Self: Sized, | ||
| { | ||
| // No-op | ||
| db | ||
| } |
There was a problem hiding this comment.
Interestingly enough, this change also means that one does not actually need to use #[salsa::db] on trait impls for the baseline Database
CodSpeed Performance ReportMerging #750 will improve performances by 8.52%Comparing Summary
Benchmarks breakdown
|
That way salsa can build without having to build the proc-macro ecosystem, improving build times for dependants of salsa
Veykril
force-pushed
the
veykril/push-szqzqmmrqqxt
branch
from
e13f1d3 to
fa8c391
Compare
Veykril
commented
Mar 8, 2025
Comment on lines
+92
to
+95
| #[doc(hidden)] | ||
| fn zalsa_register_downcaster(&self) { | ||
| // The no-op downcaster is special cased in view caster construction. | ||
| } |
There was a problem hiding this comment.
The perf changes come from this being a no-op now, so they are kind of fake as you only get that benefit if you don't use a custom database trait, and more importantly, you only really hit this when the ingredient cache fails which in a usual setup with a single database is no the case (our benches create a bunch of databases making the ingredient cache useless for them)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That way salsa can build without having to build the proc-macro ecosystem, improving build times for dependants of salsa