Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Rework home page featured collections layout #2466

Closed
wants to merge 1 commit into from

Conversation

sjproctor
Copy link
Collaborator

Story: [i240] Featured Collections Home Page Layout

Ref:

Expected Behavior Before Changes

Previous changes to the Featured Collections section on the home page layout of the Neutral Theme for logged out users created layout issues in the Featured Collections section on the home page layout of the Default Theme

Expected Behavior After Changes

A conditional statement will allow theme with Featured Collections in a grid to have different styling applied than the themes with a table layout

Screenshots / Video

Photo: theme with a grid layout Screenshot 2025-02-19 at 6 15 11 PM
Photo: theme with a table layout

image

@samvera/hyku-code-reviewers

This commit:
- added a conditional block for themes that display featured collections
in a grid layout on the home page for logged out users
- reverts a change that impacted the default theme's display of featured
collections on the home page for logged out users
- added specs to ensure correct page layout for the various themes

Ref:
- notch8/palni_palci_knapsack#240
@sjproctor sjproctor added the ignore-for-release ignore this for release notes label Feb 20, 2025
Copy link
Collaborator

@laritakr laritakr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should condition the views with the hardcoded theme name. Each theme has a theme view directory where you should be able to make a copy of the partial which should work for that theme.

Is there a reason this didn't work for this partial?

Copy link

Test Results

    3 files  ±0      3 suites  ±0   17m 51s ⏱️ +40s
2 068 tests +4  2 012 ✅ +4  56 💤 ±0  0 ❌ ±0 
2 095 runs  +4  2 037 ✅ +4  58 💤 ±0  0 ❌ ±0 

Results for commit 6843690. ± Comparison against base commit d3a0541.

This pull request removes 43 and adds 47 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy db09b465-1746-49b3-a940-6df17688b479
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit ceed88e4-82f1-4d51-939a-8bb7acdf6408
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 4ea73165-88af-46e4-9ddb-8578c23296f7
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 80db712c-5c17-4519-b4da-844d96ecfef6
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 83706465-3856-4e81-9d31-2676c5b4f0b8
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 888331af-0df0-45bb-a47b-34735bc6980a
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 841d0810-752b-4f9c-b960-ec3619347760
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update c4eb6737-853b-4678-afa5-484de57dc511
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 5c282952-20f6-49f6-8346-8136a4f5dcde
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 5e572334-7cdb-4d00-b7e7-892b63558f9a
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy e183b37e-88fb-4558-b57c-6bdbc80c9de7
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 908ba65a-e102-4b7c-b934-acaa3d63527a
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 0b3b2865-6ed4-4a5c-b938-3e34d3379865
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update fe3ef557-84e7-4f79-abd5-4710e9e1efb6
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 23a6ca0c-55f3-445c-b508-572ac3e8d822
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit feb6fc0f-a5b1-4dda-9e84-070221288267
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 9ba1b34c-13d1-4b9b-bf5c-3ab66edb3762
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update b3ad2147-2bfe-4162-8d21-e579af6f46ce
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 39d4b83e-f2ec-4436-97fc-810a1571f8dc
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 81c7e089-2e4e-45f8-a32f-3c9930308286
…

@sjproctor sjproctor closed this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release ignore this for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants