-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Rework home page featured collections layout #2466
Conversation
This commit: - added a conditional block for themes that display featured collections in a grid layout on the home page for logged out users - reverts a change that impacted the default theme's display of featured collections on the home page for logged out users - added specs to ensure correct page layout for the various themes Ref: - notch8/palni_palci_knapsack#240
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should condition the views with the hardcoded theme name. Each theme has a theme view directory where you should be able to make a copy of the partial which should work for that theme.
Is there a reason this didn't work for this partial?
Test Results 3 files ±0 3 suites ±0 17m 51s ⏱️ +40s Results for commit 6843690. ± Comparison against base commit d3a0541. This pull request removes 43 and adds 47 tests. Note that renamed tests count towards both.
|
Story: [i240] Featured Collections Home Page Layout
Ref:
Expected Behavior Before Changes
Previous changes to the Featured Collections section on the home page layout of the Neutral Theme for logged out users created layout issues in the Featured Collections section on the home page layout of the Default Theme
Expected Behavior After Changes
A conditional statement will allow theme with Featured Collections in a grid to have different styling applied than the themes with a table layout
Screenshots / Video
Photo: theme with a grid layout
Photo: theme with a table layout
@samvera/hyku-code-reviewers