Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I240 featured collections columns #2467

Merged
merged 4 commits into from
Feb 20, 2025
Merged

Conversation

sjproctor
Copy link
Collaborator

Story: [i240] Featured Collections

Ref:

Expected Behavior Before Changes

The default theme's featured collection section on the logged out home page uses a table layout where all the other themes should use a grid layout but were rendering in a column.

Expected Behavior After Changes

All featured collection section on the logged out home page should follow the theme's desired structure.

Screenshots / Video

Photo: Default theme featured collection section on the logged out home page

image

Photo: Cultural theme featured collection section on the logged out home page

image

Photo: Institutional theme featured collection section on the logged out home page

image

Photo: Neutral theme featured collection section on the logged out home page

image

@samvera/hyku-code-reviewers

This commit:
- added a conditional block for themes that display featured collections
in a grid layout on the home page for logged out users
- reverts a change that impacted the default theme's display of featured
collections on the home page for logged out users
- added specs to ensure correct page layout for the various themes

Ref:
- notch8/palni_palci_knapsack#240
This commit:
- adds a new partial to the Cultural Repository theme to render the
featured collections in a grid format rather than a table
- add a spec for the Cultural Repository featured collection partial
- reverts previous changes to the default theme featured collection
layout partial and corresponding spec file

Ref:
- notch8/palni_palci_knapsack#240
This commit:

- adds a new partial to the Institutional Repository theme to render the
featured collections in a grid format rather than a table
- adds a spec for the Institutional Repository featured collection partial

Ref:
- notch8/palni_palci_knapsack#240
This commit:
- adds a new partial to the Neutral Repository theme to render
the featured collections in a grid format rather than a table
- adds a spec for the Neutral Repository featured collection
partial

Ref:
- notch8/palni_palci_knapsack#240
@sjproctor sjproctor added the ignore-for-release ignore this for release notes label Feb 20, 2025
Copy link

Test Results

    3 files  ± 0      3 suites  ±0   17m 6s ⏱️ -5s
2 079 tests +15  2 023 ✅ +15  56 💤 ±0  0 ❌ ±0 
2 106 runs  +15  2 048 ✅ +15  58 💤 ±0  0 ❌ ±0 

Results for commit 1e3c7af. ± Comparison against base commit d3a0541.

This pull request removes 42 and adds 57 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy db09b465-1746-49b3-a940-6df17688b479
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit ceed88e4-82f1-4d51-939a-8bb7acdf6408
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 4ea73165-88af-46e4-9ddb-8578c23296f7
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 80db712c-5c17-4519-b4da-844d96ecfef6
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 83706465-3856-4e81-9d31-2676c5b4f0b8
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 888331af-0df0-45bb-a47b-34735bc6980a
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 841d0810-752b-4f9c-b960-ec3619347760
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update c4eb6737-853b-4678-afa5-484de57dc511
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 5c282952-20f6-49f6-8346-8136a4f5dcde
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 5e572334-7cdb-4d00-b7e7-892b63558f9a
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy de2573f0-f559-473b-b065-f224dc1e7041
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 9bd31ae5-aa06-49a2-9907-ef096badc2b3
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 083a7f72-7380-41b8-a738-4c1a8850860e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update ca7ea76a-02cb-44db-881c-f4d5994e3add
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy feaa1708-db53-4fa6-a68e-da0dea74ddde
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 6e914756-c737-4481-957a-612a6d0efcfb
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 82c32812-15b4-4b5b-8632-2b66bf83bc6f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 31580b66-0dd0-498e-92d7-51642fc29c70
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 95100a2f-4fb5-4e8d-841f-d0a3eb94d0ca
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 43529ece-2fc9-4006-92b4-44077fcc67e1
…

@sjproctor sjproctor merged commit a3c450c into main Feb 20, 2025
9 checks passed
@sjproctor sjproctor deleted the i240-featured-collections-columns branch February 20, 2025 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release ignore this for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants