-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I240 featured collections columns #2467
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit: - added a conditional block for themes that display featured collections in a grid layout on the home page for logged out users - reverts a change that impacted the default theme's display of featured collections on the home page for logged out users - added specs to ensure correct page layout for the various themes Ref: - notch8/palni_palci_knapsack#240
This commit: - adds a new partial to the Cultural Repository theme to render the featured collections in a grid format rather than a table - add a spec for the Cultural Repository featured collection partial - reverts previous changes to the default theme featured collection layout partial and corresponding spec file Ref: - notch8/palni_palci_knapsack#240
This commit: - adds a new partial to the Institutional Repository theme to render the featured collections in a grid format rather than a table - adds a spec for the Institutional Repository featured collection partial Ref: - notch8/palni_palci_knapsack#240
This commit: - adds a new partial to the Neutral Repository theme to render the featured collections in a grid format rather than a table - adds a spec for the Neutral Repository featured collection partial Ref: - notch8/palni_palci_knapsack#240
laritakr
approved these changes
Feb 20, 2025
Test Results 3 files ± 0 3 suites ±0 17m 6s ⏱️ -5s Results for commit 1e3c7af. ± Comparison against base commit d3a0541. This pull request removes 42 and adds 57 tests. Note that renamed tests count towards both.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story: [i240] Featured Collections
Ref:
Expected Behavior Before Changes
The default theme's featured collection section on the logged out home page uses a table layout where all the other themes should use a grid layout but were rendering in a column.
Expected Behavior After Changes
All featured collection section on the logged out home page should follow the theme's desired structure.
Screenshots / Video
Photo: Default theme featured collection section on the logged out home page
Photo: Cultural theme featured collection section on the logged out home page
Photo: Institutional theme featured collection section on the logged out home page
Photo: Neutral theme featured collection section on the logged out home page
@samvera/hyku-code-reviewers