-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rework user_analytics setting #2469
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removes user_analytics and rely on analytics_reporting instead. - adds conditional to determine if jobs should be enqueued based on settings - adds help text describing the settings - adds specs
laritakr
previously approved these changes
Feb 21, 2025
Test Results 3 files ±0 3 suites ±0 17m 23s ⏱️ -1s Results for commit ca857c7. ± Comparison against base commit 6f956d0. This pull request removes 42 and adds 50 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
ShanaLMoore
commented
Feb 21, 2025
laritakr
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Don't run UserStatCollectionJob if Ga4 creds aren't set notch8/palni_palci_knapsack#267
removes user_analytics and rely on analytics_reporting instead.
adds conditional to determine if jobs should be enqueued based on settings
adds help text describing the settings
adds specs
TODO: Add error handling to hyrax job
samvera/hyrax#7029