Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework user_analytics setting #2469

Merged
merged 3 commits into from
Feb 24, 2025
Merged

Conversation

ShanaLMoore
Copy link
Collaborator

@ShanaLMoore ShanaLMoore commented Feb 21, 2025

Issue:

TODO: Add error handling to hyrax job
samvera/hyrax#7029

- removes user_analytics and rely on analytics_reporting instead.
- adds conditional to determine if jobs should be enqueued based on settings
- adds help text describing the settings
- adds specs
@ShanaLMoore ShanaLMoore added the patch-ver for release notes label Feb 21, 2025
laritakr
laritakr previously approved these changes Feb 21, 2025
Copy link

github-actions bot commented Feb 21, 2025

Test Results

    3 files  ±0      3 suites  ±0   17m 23s ⏱️ -1s
2 087 tests +8  2 031 ✅ +8  56 💤 ±0  0 ❌ ±0 
2 114 runs  +8  2 056 ✅ +8  58 💤 ±0  0 ❌ ±0 

Results for commit ca857c7. ± Comparison against base commit 6f956d0.

This pull request removes 42 and adds 50 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 3c2ab790-2b83-4833-944f-e98d4f0dc636
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 2393acf2-a988-4757-aefe-f5afc48b4314
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 9ad31598-8e73-49de-87d7-ca39f15df845
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update dce53e6d-c81b-4c7a-9f7f-5dc2369661b9
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy b044598c-1452-4b09-ad69-ad1861887c32
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 35d0757a-44bb-4e2f-b92c-1492bdf75caf
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 2d3decba-3b6f-4d61-a324-202409b414d1
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 1b8dda13-747b-4fa8-8866-748d734b127c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 6010db34-b04d-468a-89ef-74ac68f68224
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 28a45b89-1ec7-424a-8708-3f7d06962bcc
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 0941c5fb-8334-4f54-bf62-4d2651fcb5a7
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit b5358a69-7e51-4b0e-999f-1415cc4f2510
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 36a9eeb8-32e2-456e-8aaa-38eaedd65f5a
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update b8c5767c-e477-4bb5-80d1-4b77d092b949
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 17470280-b485-4a72-83cf-248694abfe74
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 8042818a-d6c0-4d85-9786-1518cd275707
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read f3f1d07e-0d6c-4be6-b13e-97560be39ec6
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 3facc823-d7df-4fac-b392-c4d19d779e2c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 17f53abd-ae5d-4a15-a7d5-5187076277cd
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 1fc50cd9-4335-449a-963e-178bee7d14ce
…

♻️ This comment has been updated with latest results.

@ShanaLMoore ShanaLMoore marked this pull request as ready for review February 21, 2025 22:52
@ShanaLMoore ShanaLMoore requested a review from laritakr February 22, 2025 20:45
@ShanaLMoore ShanaLMoore merged commit 4614f8c into main Feb 24, 2025
14 of 16 checks passed
@ShanaLMoore ShanaLMoore deleted the i267-guard-user-stat-collection-job branch February 24, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants