Merge pull request #308 from samvera-labs/private_members

Move member_ids to private visibility
samvera · Nov 13, 2017 · 54e0af2 · 54e0af2
2 parents 886035e + fcb8827
commit 54e0af2
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/valkyrie/lib/valkyrie/persistence/memory/query_service.rb b/valkyrie/lib/valkyrie/persistence/memory/query_service.rb
@@ -84,17 +84,18 @@ def find_parents(resource:)
       end
     end
 
-    def member_ids(resource:)
-      return [] unless resource.respond_to? :member_ids
-      resource.member_ids || []
-    end
-
     def custom_queries
       @custom_queries ||= ::Valkyrie::Persistence::CustomQueryContainer.new(query_service: self)
     end
 
     private
 
+      # @return [Array<Valkyrie::ID>] a list of the identifiers of the member objects
+      def member_ids(resource:)
+        return [] unless resource.respond_to? :member_ids
+        resource.member_ids || []
+      end
+
       def validate_id(id)
         raise ArgumentError, 'id must be a Valkyrie::ID' unless id.is_a? Valkyrie::ID
       end