use ES modules #23
Merged
use ES modules #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidchambers
commented
Dec 12, 2023
| @@ -2,4 +2,3 @@ repo-owner = sanctuary-js | |||
| repo-name = sanctuary-show | |||
| contributing-file = .github/CONTRIBUTING.md | |||
| heading-level = 3 | |||
| module-type = commonjs | |||
There was a problem hiding this comment.
module-type defaults to esm as of sanctuary-js/sanctuary-scripts#56.
davidchambers
commented
Dec 12, 2023
davidchambers
commented
Dec 12, 2023
Comment on lines
+11
to
+14
| "exports": { | ||
| ".": "./index.js", | ||
| "./package.json": "./package.json" | ||
| }, |
There was a problem hiding this comment.
https://nodejs.org/api/packages.html#package-entry-points
I want to continue to support importing from sanctuary-show/package.json as I consider this part of the public API.
davidchambers
commented
Dec 12, 2023
|
|
||
| const assert = require ('assert'); | ||
| import show from 'sanctuary-show'; |
There was a problem hiding this comment.
Avaq
approved these changes
Dec 12, 2023
davidchambers
force-pushed
the
davidchambers/esm
branch
from
c3a0bd3 to
e736c23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sanctuary-js/sanctuary#726