Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve on random() #190

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Improve on random() #190

Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b5c6842
Improve on random()
WereCatf Sep 25, 2018
e9bec96
Attempt to fix compilation for mkrwan1300
WereCatf Sep 25, 2018
32a8d16
Actually try to fix mkrwan1300
WereCatf Sep 25, 2018
f36fe47
Yield()ing for ESP WDT, just in case
WereCatf Sep 26, 2018
eb98ea9
Take onReceive() into account in random()
WereCatf Oct 5, 2018
00cf0a3
Merge remote-tracking branch 'sandeepmistry/master' into master
Nov 3, 2020
0a4e6ba
Update info about this fork
Nov 3, 2020
558d35b
Fix README.md
Nov 3, 2020
1413d92
Adjust library.properties
May 16, 2021
14a1ca8
More random random()
May 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion src/LoRa.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,7 +582,26 @@ void LoRaClass::setOCP(uint8_t mA)

byte LoRaClass::random()
{
return readRegister(REG_RSSI_WIDEBAND);
uint8_t currMode = readRegister(REG_OP_MODE);
uint8_t retVal = 0;

while(isTransmitting());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it need a yield() call in this loop so the WDT doesn't fire on platforms like ESP8266/32?


//We need to be listening to radio-traffic in order to generate random numbers
if(currMode != (MODE_LONG_RANGE_MODE | MODE_RX_CONTINUOUS)){
#ifndef ARDUINO_SAMD_MKRWAN1300
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm generally oppose to these kinds of checks, since this PR was originally submit, 'support' has been added for the 1310 board(sorry this hasn't got attention...) and doesn't even begin to handle many other boards out there. Can this check instead be performed against _onReceive itself?

receive();
#else
explicitHeaderMode();
writeRegister(REG_OP_MODE, MODE_LONG_RANGE_MODE | MODE_RX_CONTINUOUS);
#endif
delay(1);
}
retVal = readRegister(REG_RSSI_WIDEBAND);
//Put the radio in the same mode as it was
if(currMode != (MODE_LONG_RANGE_MODE | MODE_RX_CONTINUOUS)) writeRegister(REG_OP_MODE, currMode);

return retVal;
}

void LoRaClass::setPins(int ss, int reset, int dio0)
Expand Down