Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate battery sensor entity for SOMRIG devices #33

Merged
merged 3 commits into from
Apr 20, 2024

Conversation

bjorncs
Copy link
Contributor

@bjorncs bjorncs commented Apr 13, 2024

No description provided.

@bjorncs bjorncs changed the title Bjorncs/somrig Remove duplicate battery sensor entity for SOMRIG devices Apr 20, 2024
@bjorncs bjorncs marked this pull request as ready for review April 20, 2024 06:31
@bjorncs
Copy link
Contributor Author

bjorncs commented Apr 20, 2024

@sanjoyg @slajob: I have simplified the solution. Please review and merge if you agree with the new approach.

@slajob
Copy link
Collaborator

slajob commented Apr 20, 2024

Checked and works. Duplicated entity with somrig id is gone.

@slajob slajob merged commit 97424cd into sanjoyg:main Apr 20, 2024
3 checks passed
@bjorncs bjorncs deleted the bjorncs/somrig branch April 20, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants