Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(IAC-407) feature: Enable running static checks in Azure IaC repo via pre-commit tool #223

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

dhoucgitter
Copy link
Member

@dhoucgitter dhoucgitter commented Feb 15, 2022

Why:

Wish to enable use of existing linter static checks, and any other new ones from developer sandbox.
In an effort to shift left static lint checks already in place for Azure IaC GitHub repo PR/merges
Note: This PR also includes the update for IAC-421 which updates the tflint tool configuration and touches the same file that IAC-407 requires.

…it tool

Why:

Shift left static lint checks already in place for Azure IaC GitHub repo PR/merges
Copy link
Member

@thpang thpang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jarpat jarpat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@dhoucgitter dhoucgitter linked an issue Feb 17, 2022 that may be closed by this pull request
1 task
@dhoucgitter dhoucgitter merged commit 6b1e2f5 into main Feb 17, 2022
@dhoucgitter dhoucgitter deleted the iac-407_a branch February 17, 2022 14:16
@dhoucgitter dhoucgitter added the enhancement New feature or request label Feb 17, 2022
@dhoucgitter dhoucgitter self-assigned this Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(IAC-421) Fix: tflint issue with default_nodepool_vm_type value
3 participants