Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excluded /archives from sitemap if this feature is disabled #425

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

kkomelin
Copy link
Contributor

@kkomelin kkomelin commented Dec 8, 2024

Description

Currently if SITE.showArchives == false, we still include the /archives page into the XML sitemap, which causes an issue in Google Search Console.

Types of changes

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Documentation Update (if none of the other choices apply)
  • Others (any other types not listed above)

Checklist

  • I have read the Contributing Guide
  • I have added the necessary documentation (if appropriate)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)

Further comments

Related Issue

Closes: #

@satnaing
Copy link
Owner

satnaing commented Jan 5, 2025

Thanks for the fix.

@satnaing satnaing merged commit c2e2dbd into satnaing:main Jan 5, 2025
1 check passed
@kkomelin
Copy link
Contributor Author

kkomelin commented Jan 5, 2025

Thanks for the review @satnaing !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants