Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sky segmentation #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

maysa-mayel
Copy link

@maysa-mayel maysa-mayel commented Oct 21, 2024

Summary

This pull request adds a new Jupyter notebook for sky segmentation using the DeepLabV3 model fine tuned on cityscapes dataset.

Changes Made

  • Implemented segmentation logic in the notebook.
  • Added visualizations of the segmented images.
  • Organized code into functions for clarity.

Instructions

  • Ensure the required packages are installed.
  • Run the notebook to see the segmentation results.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@@ -0,0 +1,702 @@
{
Copy link
Owner

@sayakpaul sayakpaul Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm the model seems a bit suboptiomal no? For example, the edge of the roof of the building -- it seems it's a little different from the original picture. Is it a result of resizing?


Reply via ReviewNB

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's due to resizing. I'll adjust the logic to preserve aspect ratio or use padding and update the code.

@maysa-mayel maysa-mayel changed the title add notebook for sky segmentation sky segmentation Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants