Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #33 : Move to Sonar Scanner 3.x #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chris-barry
Copy link
Collaborator

In this PR I:

  • Upgraded from sonar-scanner to sonar-runner in order to support modern versions of SonarQube
    • sonar-runner-dist-2.4 -> sonar-scanner-cli-3.2.0.1227
  • Moved the .travis.yml node version from 0.10 to 8, the current LTS release
  • Removed the option projectHome since I cannot find it in SonarQube documentation
  • Add the LGPL to the sonar-runner directory, as required by the SonarQube license
  • Upgraded dev dependencies, where possible

I have tested this locally on a Debian machine and it seems to work.

@chris-barry chris-barry requested a review from pointful October 26, 2018 18:51
@pointful
Copy link
Member

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants