-
Notifications
You must be signed in to change notification settings - Fork 163
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
lint: move linters from oncilla/gochecks
Move the linters from https://github.com/oncilla/gochecks and update them to the updated package paths. Closes #4174 GitOrigin-RevId: 219b897858ff56ff94dd7103ab0d44aad283282e
- Loading branch information
Showing
19 changed files
with
814 additions
and
82 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| bin | ||
| docker/_build | ||
| rules_openapi/tools/node_modules | ||
| tools/lint/logctxcheck/testdata/src |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| load("//tools/lint:go.bzl", "go_library") | ||
|
|
||
| go_library( | ||
| name = "go_default_library", | ||
| srcs = ["lint.go"], | ||
| importpath = "github.com/scionproto/scion/tools/lint", | ||
| visibility = ["//visibility:public"], | ||
| deps = ["@org_golang_x_tools//go/analysis:go_default_library"], | ||
| ) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| // Copyright 2022 Anapaya Systems | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| // Package lint contains helpers for linting and static analysis. | ||
| package lint | ||
|
|
||
| import ( | ||
| "bytes" | ||
| "fmt" | ||
| "go/ast" | ||
| "go/printer" | ||
| "go/token" | ||
| "go/types" | ||
| "path" | ||
| "strings" | ||
|
|
||
| "golang.org/x/tools/go/analysis" | ||
| ) | ||
|
|
||
| // FindPackageNames returns all the imported packages mapped to their name in | ||
| // the file. | ||
| func FindPackageNames(file *ast.File) map[string]string { | ||
| pkgs := map[string]string{} | ||
| for _, imp := range file.Imports { | ||
| pkg := strings.Trim(imp.Path.Value, `"`) | ||
| name := path.Base(pkg) | ||
| if imp.Name != nil { | ||
| name = imp.Name.Name | ||
| } | ||
| pkgs[pkg] = name | ||
| } | ||
| return pkgs | ||
| } | ||
|
|
||
| // IsString checks if the underlying type of the literal is string. | ||
| func IsString(pass *analysis.Pass, lit ast.Expr) bool { | ||
| t, ok := pass.TypesInfo.TypeOf(lit).Underlying().(*types.Basic) | ||
| return ok && t.Info()&types.IsString != 0 | ||
| } | ||
|
|
||
| // RenderList renders the list of expressions. | ||
| func RenderList(fset *token.FileSet, list []ast.Expr) string { | ||
| var p []string | ||
| for _, arg := range list { | ||
| p = append(p, Render(fset, arg)) | ||
| } | ||
| return fmt.Sprintf("[%s]", strings.Join(p, ",")) | ||
| } | ||
|
|
||
| // Render renders the the expression. | ||
| func Render(fset *token.FileSet, x interface{}) string { | ||
| var buf bytes.Buffer | ||
| if err := printer.Fprint(&buf, fset, x); err != nil { | ||
| panic(err) | ||
| } | ||
| return buf.String() | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| load("//tools/lint:go.bzl", "go_library", "go_test") | ||
|
|
||
| go_library( | ||
| name = "go_default_library", | ||
| srcs = ["analyzer.go"], | ||
| importpath = "github.com/scionproto/scion/tools/lint/logctxcheck", | ||
| visibility = ["//visibility:public"], | ||
| deps = [ | ||
| "//tools/lint:go_default_library", | ||
| "@org_golang_x_tools//go/analysis:go_default_library", | ||
| ], | ||
| ) | ||
|
|
||
| go_test( | ||
| name = "go_default_test", | ||
| srcs = ["analyzer_test.go"], | ||
| data = glob(["testdata/**"]), | ||
| deps = [ | ||
| ":go_default_library", | ||
| "@org_golang_x_tools//go/analysis/analysistest:go_default_library", | ||
| ], | ||
| ) |
Oops, something went wrong.