Only print coverage report to console on success. #343
+18
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it much easier to see errors when they happen.
Also:
- Make ./scion.sh test and ./scion.sh coverage work with test filenames
directly. E.g., this now works:
./scion.sh coverage test/lib_zookeeper_test.py
- Cleaned up .gitignore a bit, making patterns anchored at the root of
the repository when applicable (as this was hiding some issues).
|
Merging, @pszalach can review when he's back. |
kormat
added a commit
that referenced
this pull request
Aug 27, 2015
Only print coverage report to console on success.
|
lgtm |
FR4NK-W
pushed a commit
to FR4NK-W/osourced-scion
that referenced
this pull request
Feb 14, 2017
Only print coverage report to console on success.
sgmonroy
pushed a commit
to sgmonroy/scion
that referenced
this pull request
Feb 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it much easier to see errors when they happen.
Also:
directly. E.g., this now works:
./scion.sh coverage test/lib_zookeeper_test.py
the repository when applicable (as this was hiding some issues).