doc: fixup certificate copying in deploy tutorial #4467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiceatscion
approved these changes
Feb 19, 2024
Fix copying of certificates to individual hosts in the "freestanding deployment" tutorial. Was suggesting to copy all certificates to `/etc/scion/crypto/`. Instead, it should copy the AS certificates to `/etc/scion/crypto/as/`. Originally the instructions had been correct; the problem was introduced with the custom script to generate the crypto material. This script uses flatter paths (for brevity) than the originally used `scion-pki testcrypto` tool, and the copy instruction were not correctly updated (and not tested, duh).
matzf
force-pushed
the
doc-tutorial-deploy-fixup
branch
from
ad28b3a to
1fc0d5d
Compare
jiceatscion
approved these changes
Feb 20, 2024
jiceatscion
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @matzf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix copying of certificates to individual hosts in the "freestanding deployment" tutorial.
Was suggesting to copy all certificates to
/etc/scion/crypto/. Instead, it should copy the AS certificates to/etc/scion/crypto/as/.Originally the instructions had been correct; the problem was introduced with the custom script to generate the crypto material. This script uses flatter paths (for brevity) than the originally used
scion-pki testcryptotool, and the copy instruction were not correctly updated (and not tested, duh).This change is