testing: router benchmark, multiplex external br interfaces on one veth pair #4468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes no difference, performance-wise as each test case uses exactly ones of the external interfaces. However, it reduces the infrastructure required to run benchmarks on real devices: minimum 4 switch ports instead of minimum 6.
matzf
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
The representation of this interface grouping in topology information with this exclusive bit does not seem entirely straight forward when reading this. The alternatives do seem just as complex though.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jiceatscion)
matzf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes no difference, performance-wise as each test case uses exactly ones of the external interfaces. However, it reduces the infrastructure required to run benchmarks on real devices: minimum 4 switch ports instead of minimum 6.
This change is