Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update supervisor to version 4.2.5. #4469

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

jiceatscion
Copy link
Contributor

@jiceatscion jiceatscion commented Feb 19, 2024

The old version depends on the asynchat std module, which has been removed from python 3.12.


This change is Reviewable

The old version depends on the asynchat std module, which has been removed from
python 3.12.
@jiceatscion jiceatscion requested a review from matzf February 19, 2024 16:20
@matzf matzf changed the title Update supervisor to version 4.2.5. deps: update supervisor to version 4.2.5. Feb 20, 2024
Copy link
Contributor

@matzf matzf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jiceatscion)


tools/env/pip3/requirements.txt line 70 at r1 (raw file):

# The following packages are considered to be unsafe in a requirements file:
setuptools==69.1.0 \

Just for the record; this setuptools version is not compatible with ancient python 3.6, and thus the install dependency script will no longer work on also ancient Ubuntu 18.04.
This seems ok. If necessary, it can still be made to work easily by changing this requirement to an older version of setuptools.

@jiceatscion jiceatscion merged commit 7bb1ff4 into scionproto:master Feb 20, 2024
4 checks passed
@jiceatscion jiceatscion deleted the supervisor_update branch February 20, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants