cmd/scion, snet: reduce range of IDs for SCMP requests #4495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preparation for dispatcher-less endpoints. Reduce the range of IDs used for SCMP requests, to be forward-compatible with the default range for port-dispatching in the router. In the dispatcher-less future, the router will forward SCMP reply messages to an application's underlay port determined based on the SCMP message ID. For this, the router will have a configurable range of ports for which it applies the dispatching, allowing dispatcher-ful and dispatcher-less endpoints to coexist. This port range will need to be disjoint from the port range currently used by the dispatcher and SCMP request identifiers.
|
This change is |
jiceatscion
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @matzf)
jiceatscion
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Reviewable status:
lukedirtwalker
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation for dispatcher-less endpoints. Reduce the range of IDs used for SCMP requests, to be forward-compatible with the default range for port-dispatching in the router.
In the dispatcher-less future, the router will forward SCMP reply messages to an application's underlay port determined based on the SCMP message ID. For this, the router will have a configurable range of ports for which it applies the dispatching, allowing dispatcher-ful and dispatcher-less endpoints to coexist. This port range will need to be disjoint from the port range currently used by the dispatcher and SCMP request identifiers.
For more details, see design document, #4280.