feat: Make notebooks runnable on previous data #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Retain the data directory to ensure it exists. * Add the data/ directory to .gitignore
* Correct typo: 'track_id' -> 'track_ids' * Use `tolist` to make object JSON serializable. - NumPy arrays can't be JSON serialized.
matthewfeickert
changed the title
* Avoids potential errors and warnings and removes OS dependent paths.
* Add pre-processing and assignments task. * Add run instructions to README.
matthewfeickert
force-pushed
the
feat/make-runnable
branch
from
221894e to
03ff4ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
.gitkeepfor thedata/directory and also add it to.gitignore.pathlib.Pathto avoid potential errors and allow changing ofoutputdirectory to be at the top level of the project.pixitask runner commands as well as instructions to the README.As this PR does more than 1 thing, it isn't very atomic (and so less fun to review). It can be easily split into multiple more atomic PRs though, which I'd be happy to do if that's nicer.
We can also discuss in the 2024-04-01 Program meeting.
(PR was done on plane, but for some reason couldn't get pushed out over plane WiFi, so had to wait till I got to a coffee shop.)
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?