Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linux aarch64 wheel build support #13

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

odidev
Copy link
Contributor

@odidev odidev commented Sep 22, 2021

Add linux aarch64 wheel build support.

Related to #12 @scoder Could you please review this PR?

@scoder
Copy link
Owner

scoder commented Sep 22, 2021

lxml already has a better Makefile implementation that avoids duplicating the entire build script:

https://github.com/lxml/lxml/blob/5c8edfa39b0e31490a581740aaff44656ec72348/Makefile#L61-L65

Could you try to adapt that?

That said, I'd rather not run that build locally on my machine since the emulation makes it horribly slow. Would be nice to have Github Actions do it for me.

@odidev
Copy link
Contributor Author

odidev commented Sep 24, 2021

@scoder I have done the changes as per your suggestions. Please take a look.

@odidev
Copy link
Contributor Author

odidev commented Oct 20, 2021

@scoder, could you please review this PR? Thanks.

@scoder
Copy link
Owner

scoder commented Oct 20, 2021

How very nice! Thanks!

@scoder scoder merged commit e1068f0 into scoder:master Oct 20, 2021
@odidev
Copy link
Contributor Author

odidev commented Oct 20, 2021

@scoder, may I know the plan for releasing AArch64 wheels? Thanks.

@kmaehashi
Copy link

Great work, @odidev! I'm also interested in the aarch64 wheel availability as I'm planning to release CuPy wheels for aarch64.

@scoder
Copy link
Owner

scoder commented Oct 20, 2021

I'll push them out as soon as I have everything up and running. During the next days.

Looks like the PGO build is failing for aarch64, probably due to resource problems on the virtual machine. I'll see if I can reduce the benchmark run overhead.

@scoder
Copy link
Owner

scoder commented Oct 20, 2021

It also seems worth building the wheels in separate GHA matrix jobs. Especially the AArch64 wheels take very long to build in the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants