-
-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Lua 5.1.5 and 5.2.4 source code #234
Conversation
Thanks. When you write "doesn't have tags", do you mean that it doesn't include the commit IDs either? Meaning, the code is really not there? Or are only the tags missing? I'd rather not have these sources in the repo. If there's a way to get them via an external subrepo, I'd prefer that. Doesn't have to be github, just some sort-of official repo. |
At least for the 5.2 branch, there seem to be commits after 5.2.3: The 5.1 branch has apparently been deleted already. |
It's kind of complicated because that GitHub repo is "synced from another RCS repository" and the only official site to download their code is https://www.lua.org/ftp. Please see the Lua maintainer's comment at here: lua/lua#16 (comment) |
83b789f
to
bf4c5f2
Compare
The build finally passed this time... Only the |
I guess Lua 5.1 doesn't collect garbage when |
I've updated the Lua 5.2 subrepo in the master branch to the latest commit in that branch. Let's use that. The last commit there seems to indicate that Lua 5.2.4 had been released at that point. Personally, I think that Lua 5.1 is long out of maintenance for good reason, and shouldn't be used any more, but if we can still support it without much effort, then let's just add the sources to Lupa. It just makes the distro and repo a little larger. Someone out there can probably still make use of it. |
That branch lacks some files in the .tar.gz file but that probably doesn't matter, most C code are the same.
My main reason to create this pull request is for the https://github.com/tatuylonen/wiktextract project, they have to run some Lua 5.1 code because MediaWiki is still using 5.1.5. |
The Lua GitHub repository doesn't have the 5.1.5 tag, and the code downloaded from https://www.lua.org/ftp has different directory layout.
Don't run Lua code after decreasing memory limit. Lua 5.1 seems can't free the memory of the `a` variable after deleting it, thus it will raise `LuaMemoryError` again. And the memory limiting feature doesn't support Lua 5.1.
Thanks! |
Just another supporting data point for Lua 5.1 inclusion - Redis still bundles Lua 5.1 so being able to easily unit test any lua scripts that will be sent to redis via python is nice. |
This pull request adds the Lua 5.1.5 and 5.2.4 source files. The Lua GitHub repo doesn't have tags for those two releases, so I downloaded the code from https://www.lua.org/ftp and added them to the
third-party
directory.The
test_decrease_memory
test failed on Lua 5.1 with errornot enough memory
, but I'm not sure how to fix it yet.