-
-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pyproject.toml build file #238
Conversation
Hi @scoder, could you please review this minor change if you have the time? |
Note that |
But setuptools doesn't recognize the |
Understood. so that can probably be removed. Still, the GHA and appveyor scripts both use |
Probably not, |
setuptools doesn't have `build_requires` keyword. By using the `setup_requires` keyword, `pip install --use-pep517` will be able to install Cython before building package.
I removed the |
Thanks |
This fixes the pip install error when adding Lupa source code as dependency in other packages' pyproject.toml file because Lupa's
setup.py
doesn't install Cython automatically.Example
pyproject.toml
: